Deploy the registration service using the new SSA client #1171
Conversation
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
mfrancisc,
rsoaresd,
fbm3307 and
jrosental
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek, metlos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAttention: Patch coverage is
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 83.51% 83.56% +0.04%
==========================================
Files 82 82
Lines 7948 7926 -22
==========================================
- Hits 6638 6623 -15
+ Misses 1107 1102 -5
+ Partials 203 201 -2
🚀 New features to boost your workflow:
|
This was not as simple as initially thought because SSA client does not report the fact whether the objects were updated or not back to the caller.
This was relied upon when determining the "deploying" and "deployed" phases of the registration service as reported in the
ToolchainConfig.status.This has been discussed and we agreed to drop the distinction and merely consider the registration service not deployed or deployed.
Related PRs: